Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Wait for nodegroup updates #5395

Merged
merged 8 commits into from
Jun 16, 2022
Merged

Add Wait for nodegroup updates #5395

merged 8 commits into from
Jun 16, 2022

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Jun 10, 2022 •
edited

Description

Closes #5250

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@Skarlso Skarlso added the kind/feature New feature or request label Jun 10, 2022
@Skarlso Skarlso force-pushed the add-wait-to-update-nodegroup branch from 480d267 to b883010 Compare June 10, 2022 15:23
@Skarlso Skarlso marked this pull request as ready for review June 10, 2022 19:31
Himangini
Himangini approved these changes Jun 16, 2022
View reviewed changes
Copy link
Collaborator

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤馃徎 LGTM

@Skarlso Skarlso merged commit 61222fd into eksctl-io:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

@Himangini Himangini Himangini approved these changes

@nikimanoledaki nikimanoledaki Awaiting requested review from nikimanoledaki

Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update nodegroup does not wait for the update operation to complete
3 participants
@Skarlso @cPu1 @Himangini