Add LogRetentionInDays update to update-cluster-logging command

[Skarlso]

Description

Closes #5294

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, or the userdocs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes
• (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

[Skarlso]

Question:

This is only possible together if some kind of logging is enabled with it. So you can't just update the log retention period only together with something that is being enabled.

My suggestion is to lift this restriction and make it possible to update just the log retention period without having to enable/disable a log type.

Upon thinking about this, they will have to define logging types that are already enabled anyways. So this is fine. :)

[Himangini]

👍🏻

[fredcooke]

This is good - it'd be great it it could be configured in the yaml configuration side by side with the enabling of the types, though.

[cPu1]

This is good - it'd be great it it could be configured in the yaml configuration side by side with the enabling of the types, though.

It can be enabled in the ClusterConfig file. Here's an example.

[fredcooke]

@cPu1 thank you very much! I rolled that out earlier and it's nice to have it documented even if it doesn't take retrospective effect. :-)

[kishoregv]

Currently, eksctl is only updating the log retention days only if there is any change on the log types that are enabled or disabled.

It would be nice if log retention days is idempotently updated regardless of change in the log types.

[Skarlso]

@kishoregv hi.

See this comment:
#5404 (comment)

Basically, you'll have to change something together with enabling or disabling logging. You can't define it on its own.