-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for clusters with trn1 instance types #5906
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello dewjam 馃憢 Thank you for opening a Pull Request in eksctl
project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl
on our website
e85c37f
to
8f65bf7
Compare
Hey @Himangini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some comments for improving the validation and the integration tests.
Updated tests. This is ready for review again. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -238,20 +234,24 @@ func getAvailabilityZones(ctx context.Context, ec2API awsapi.EC2) (string, strin | |||
Expect(err).NotTo(HaveOccurred()) | |||
zones := output.AvailabilityZones | |||
|
|||
zoneMap := map[string]struct{}{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, is map[string]struct{}{} a style thing? Or is it more efficient than map[string]bool for this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's more efficient, takes fewer bytes, and is more idiomatic when you're using a map as a set.
Description
Per #5896, TRN1 instance types are now available in us-west-2 and us-east-1. This PR ensures Trn1 instance types will be launched with the EKS Accelerated AMI by default and also will install the Neuron Device Plugin by default. This also upgrades the Neuron Device Plugin to version
1.9.3.02.1.2.0 which is required for Trn1 support.Example:
Checklist
README.md
, or theuserdocs
directory)area/nodegroup
) and kind (e.g.kind/improvement
)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く