Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added slack notifications for publish docs workflow #5926

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

Himangini
Copy link
Collaborator

@Himangini Himangini commented Nov 14, 2022

Description

Closes #5900

The publish docs workflow is not well thought off when it was added originally, while it's mentioned here #5901 that the dependencies update broke the docs workflow, it's incorrect. The workflow itself is missing key steps which we have been incrementally updating from time to time.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@Himangini Himangini added area/build-and-release area/ci area/tech-debt Leftover improvements in code, testing and building labels Nov 14, 2022
@Himangini Himangini merged commit 2fcf71a into eksctl-io:main Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-and-release area/ci area/tech-debt Leftover improvements in code, testing and building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notify when publishing docs fails
2 participants