Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated set-output in workflows #5927

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

Himangini
Copy link
Collaborator

@Himangini Himangini commented Nov 14, 2022

Description

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Part of https://github.com/weaveworks/eksctl-ci/issues/63

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@Himangini Himangini added area/ci area/tech-debt Leftover improvements in code, testing and building labels Nov 14, 2022
@Himangini Himangini force-pushed the update-deprecated-github-actions branch from 3500caa to 62f922e Compare November 15, 2022 10:30
@Himangini Himangini force-pushed the update-deprecated-github-actions branch from 62f922e to fe12839 Compare November 16, 2022 13:05
@Himangini Himangini merged commit 5715eab into eksctl-io:main Nov 17, 2022
cPu1 added a commit to cPu1/eksctl that referenced this pull request Nov 25, 2022
When our GitHub Actions workflows were migrated away from the deprecated `set-output` command, the syntax was incorrect: eksctl-io#5927
This changelist fixes the syntax used for environment files.
cPu1 added a commit to cPu1/eksctl that referenced this pull request Nov 25, 2022
When our GitHub Actions workflows were migrated away from the deprecated `set-output` command, the syntax used was incorrect: eksctl-io#5927.

This changelist fixes the syntax used for environment files.
cPu1 added a commit to cPu1/eksctl that referenced this pull request Nov 25, 2022
When our GitHub Actions workflows were migrated away from the deprecated `set-output` command, the syntax used was incorrect: eksctl-io#5927.

This changelist fixes the syntax used for environment files.
@cPu1 cPu1 mentioned this pull request Nov 25, 2022
7 tasks
cPu1 added a commit that referenced this pull request Nov 25, 2022
When our GitHub Actions workflows were migrated away from the deprecated `set-output` command, the syntax used was incorrect: #5927.

This changelist fixes the syntax used for environment files.
IdanShohamNetApp pushed a commit to spotinst/weaveworks-eksctl that referenced this pull request Jan 9, 2023
When our GitHub Actions workflows were migrated away from the deprecated `set-output` command, the syntax used was incorrect: eksctl-io#5927.

This changelist fixes the syntax used for environment files.
@Himangini Himangini deleted the update-deprecated-github-actions branch September 15, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci area/tech-debt Leftover improvements in code, testing and building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants