Fix kube-proxy assertion in integration test #6226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cPu1
added
area/testing
area/ci
area/tech-debt
Himangini
reviewed
Feb 1, 2023
| @@ -119,8 +121,7 @@ var _ = Describe("(Integration) Update addons", func() { | |||
| Expect(config).To(HaveExistingStack(fmt.Sprintf("eksctl-%s-nodegroup-%s", params.ClusterName, initNG))) | |||
| }) | |||
|
|
|||
| It(fmt.Sprintf("should upgrade the control plane to version %s", nextEKSVersion), func() { | |||
|
|
|||
| It("should upgrade the control plane to the next version", func() { | |||
There was a problem hiding this comment.
do we need this change? the original line matches the assertion for lines 134 and below
There was a problem hiding this comment.
We do. nextEKSVersion is not set here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a failing assertion for kube-proxy in integration tests. When updating kube-proxy, the version is not always set to the latest version returned from
DescribeAddonVersions.Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く