Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support delegation to external load testing tools #90

Merged
merged 17 commits into from Mar 12, 2019
Merged

Support delegation to external load testing tools #90

merged 17 commits into from Mar 12, 2019

Conversation

gmemcc
Copy link
Contributor

@gmemcc gmemcc commented Mar 8, 2019

hi @stefanprodan , we found it helpful to add support for external load testing tools. in this PR loadtester package was refactored, a new test task type ngrinder was added to suport the popular performance testing platform nGrinder
please take a look, thanks:D

Gopkg.lock Show resolved Hide resolved
@stefanprodan
Copy link
Member

Hi @gmemcc this looks great. Can you please add a section in here and explain how this works with nGrinder.

Thanks

@stefanprodan stefanprodan changed the title support delegate to external load testing tool Support delegation to external load testing tools Mar 10, 2019
@codecov-io
Copy link

codecov-io commented Mar 12, 2019

Codecov Report

Merging #90 into master will increase coverage by 1.66%.
The diff coverage is 57.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage    54.8%   56.46%   +1.66%     
==========================================
  Files          13       16       +3     
  Lines        1540     1801     +261     
==========================================
+ Hits          844     1017     +173     
- Misses        556      626      +70     
- Partials      140      158      +18
Impacted Files Coverage Δ
pkg/loadtester/server.go 0% <0%> (ø) ⬆️
pkg/loadtester/task.go 100% <100%> (ø)
pkg/loadtester/runner.go 91.42% <100%> (+8.44%) ⬆️
pkg/loadtester/task_ngrinder.go 55.17% <55.17%> (ø)
pkg/loadtester/task_shell.go 76.19% <76.19%> (ø)
pkg/controller/deployer.go 57.92% <0%> (-0.79%) ⬇️
pkg/controller/job.go 0% <0%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcd5207...1bfcdba. Read the comment docs.

@gmemcc
Copy link
Contributor Author

gmemcc commented Mar 12, 2019

Hi @stefanprodan, I added a paragraph at the end of how-it-works.md, please take a look, thanks.

@fluxcd fluxcd deleted a comment from codecov-io Mar 12, 2019
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @gmemcc

@stefanprodan stefanprodan merged commit 62f4a6c into fluxcd:master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants