Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Add openAPIV3Schema validation to Helm CRD #1253

Merged
merged 4 commits into from
Jul 26, 2018
Merged

Add openAPIV3Schema validation to Helm CRD #1253

merged 4 commits into from
Jul 26, 2018

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Jul 25, 2018 •
edited
Loading

  • make git path and values required fields
  • set FluxHelmRelease short name to fhr
  • prep for multi-version CRD
  • cleanup old chart archives

@stefanprodan
Add openAPIV3Schema validation to Helm CRD
2552547 
- make release name, git path and values required fields
- set FluxHelmRelease short name to fhr
- prep for multi-version CRD
- cleanup old chart archives
@stefanprodan
Add Tiller labels back to CRD
01eb64c
squaremo
squaremo reviewed Jul 25, 2018
View reviewed changes
Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which versions of Kubernetes can understand this, and which versions of kubectl can apply this?

deploy-helm/flux-helm-release-crd.yaml Outdated
properties:
spec:
required:
- releaseName

This comment was marked as abuse.

Sign in to view

@stefanprodan
Copy link
Member Author

@squaremo the CRD validation was promoted to beta in Kubernetes 1.9

@stefanprodan
Copy link
Member Author

I will squash the commits on merge, I made a mess

@squaremo
Copy link
Member

I will squash the commits on merge, I made a mess

Squash before merging, please.

squaremo
squaremo approved these changes Jul 26, 2018
View reviewed changes
Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, thanks Stefan 💎

@stefanprodan stefanprodan merged commit ed45f41 into master Jul 26, 2018
@stefanprodan stefanprodan deleted the crd branch July 26, 2018 15:38
@squaremo
Copy link
Member

You squashed on merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@squaremo squaremo squaremo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefanprodan @squaremo