This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Add helm install timeout option #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove dead code - fix install logging
|
Hi @stefanprodan, thanks for this as I raised this issue originally. It might be 2 weeks approx before I get to try this. |
squaremo
suggested changes
Dec 10, 2018
| @@ -107,6 +107,9 @@ spec: | |||
| releaseName: | |||
| type: string | |||
| pattern: "^[a-z0-9]([-a-z0-9]*[a-z0-9])?$" | |||
| timeout: | |||
There was a problem hiding this comment.
Should this also be in the HelmRelease CRD?
There was a problem hiding this comment.
Sorry I misplaced the validation, I've moved it from FHR to HR in the latest commit.
squaremo
approved these changes
Dec 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
releasepackage and fix install loggingFix: #1545
Docker Hub image for testing:
stefanprodan/helm-operator:timeout-v5