Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Annotate resources outside of HelmRelease NS #1757

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Annotate resources outside of HelmRelease NS #1757

merged 1 commit into from
Feb 28, 2019

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Feb 22, 2019 •
edited
Loading

Fixes #1293

@hiddeco hiddeco force-pushed the helm-op-annotations-outside-release-ns branch from 2546727 to 48f37ee Compare February 25, 2019 09:46
@hiddeco hiddeco changed the title Support annotating releases outside of release ns Annotate resources outside of HelmRelease NS Feb 25, 2019
@hiddeco hiddeco marked this pull request as ready for review February 25, 2019 09:51
@hiddeco hiddeco added the helm label Feb 25, 2019
squaremo
squaremo approved these changes Feb 28, 2019
View reviewed changes
Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM as it is; I left a couple of comments where things were a little askew.

integrations/helm/release/release.go Outdated Show resolved Hide resolved
integrations/helm/release/release.go Outdated Show resolved Hide resolved
@hiddeco hiddeco force-pushed the helm-op-annotations-outside-release-ns branch from 48f37ee to 36f888c Compare February 28, 2019 15:49
squaremo
squaremo approved these changes Feb 28, 2019
View reviewed changes
Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks Hidde

@hiddeco hiddeco merged commit eca9ddc into master Feb 28, 2019
@hiddeco hiddeco deleted the helm-op-annotations-outside-release-ns branch February 28, 2019 16:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@squaremo squaremo squaremo approved these changes

@2opremio 2opremio Awaiting requested review from 2opremio

Assignees
No one assigned
Labels
helm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hiddeco @squaremo