This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Move skipDepUpdate to GitChartSource part of CRD #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Helm operator does not attempt to update dependencies for non git chart sources as packaged charts include a copy of their deps and their preferred version. This means `skipDepUpdate` pertains only to charts from git and should therefore be moved to this section of the CRD.
hiddeco
requested review from
squaremo and
stefanprodan
and removed request for
squaremo
stefanprodan
approved these changes
Mar 14, 2019
squaremo
reviewed
Mar 14, 2019
| @@ -329,7 +329,7 @@ func (chs *ChartChangeSync) reconcileReleaseDef(fhr fluxv1beta1.HelmRelease) { | |||
| chartPath = filepath.Join(chartClone.export.Dir(), chartSource.Path) | |||
| chartRevision = chartClone.head | |||
|
|
|||
| if chs.config.UpdateDeps && !fhr.Spec.SkipDepUpdate { | |||
| if chs.config.UpdateDeps && !fhr.Spec.ChartSource.GitChartSource.SkipDepUpdate { | |||
There was a problem hiding this comment.
this could use chartSource, assigned above, I think
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1782