Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Support loading values from alternative files in chart #1909

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Support loading values from alternative files in chart #1909

merged 1 commit into from
Apr 9, 2019

Conversation

arturo-c
Copy link
Contributor

@arturo-c arturo-c commented Apr 8, 2019

arturo-c pushed a commit to arturo-c/flux that referenced this pull request Apr 8, 2019
Update changelog for fluxcd#1909, improvement to valuesFrom.
1f6c40a
@arturo-c arturo-c force-pushed the add-chart-file-to-values-from branch from 1f6c40a to cbcef78 Compare April 8, 2019 23:07
@2opremio 2opremio requested a review from hiddeco April 9, 2019 06:42
hiddeco
hiddeco suggested changes Apr 9, 2019
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 thanks a lot for your contribution, this is definitely something people will like 🥇

I made 3 small suggestions, please take a look.

CHANGELOG-helmop.md Outdated Show resolved Hide resolved
integrations/helm/release/release.go Outdated Show resolved Hide resolved
integrations/helm/release/release.go Outdated Show resolved Hide resolved
@hiddeco hiddeco changed the title Adding chartFileRef option to valuesFrom, relative to chartPath pulle… Support loading values from alternative files in chart Apr 9, 2019
@hiddeco hiddeco added the helm label Apr 9, 2019
@squaremo
Copy link
Member

squaremo commented Apr 9, 2019

.oO(If we unpacked repository charts, we could support this for those as well; no need to do that in this PR though)

@arturo-c arturo-c force-pushed the add-chart-file-to-values-from branch from cbcef78 to 3f9a134 Compare April 9, 2019 13:37
@arturo-c
Copy link
Contributor Author

arturo-c commented Apr 9, 2019

@squaremo @hiddeco Thanks for the lightning fast review!, made the changes suggested, let me know how it looks

hiddeco
hiddeco reviewed Apr 9, 2019
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to my comment, can you change the message of your commit to something <=50 characters?

integrations/helm/release/release.go Outdated Show resolved Hide resolved
@arturo-c arturo-c force-pushed the add-chart-file-to-values-from branch from 3f9a134 to 8a656bc Compare April 9, 2019 13:52
@arturo-c
Copy link
Contributor Author

arturo-c commented Apr 9, 2019

In addition to my comment, can you change the message of your commit to something <=50 characters?

yup, just changed the commit message

@hiddeco hiddeco merged commit 322cdc2 into fluxcd:master Apr 9, 2019
@hiddeco
Copy link
Member

hiddeco commented Apr 9, 2019

You just officially became a Flux contributor 🎉

Thanks a lot (again) for your contribution, I think quite some people will find it useful.

@arturo-c arturo-c deleted the add-chart-file-to-values-from branch April 9, 2019 21:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@squaremo squaremo squaremo left review comments

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
helm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arturo-c @squaremo @hiddeco