This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Enqueue release on clone change only #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
approved these changes
May 23, 2019
During the refactor of synchronization mechanics in #1906, this got accidentally moved outside the condition that checks if we have a clone or it needs updating, with the result that a release is always enqueued on a signal from the mirror it is bound to. Move it back inside the condition so we only enqueue releases we actually have updates from git for.
hiddeco
force-pushed
the
helm/only-enqueue-on-clone-change
branch
from
df38c75
to
57fb1ad
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the refactor of synchronization mechanics in #1906, this got
accidentally moved outside the condition that checks if we have a clone
or it needs updating, with the result that a release is always enqueued
on a signal from the mirror it is bound to.
Move it back inside the condition so we only enqueue releases we
actually have updates from git for.