This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Use openssh-client instead of openssh apk #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The same applies to Helm Operator, can you please change it here also https://github.com/weaveworks/flux/blob/master/docker/Dockerfile.helm-operator |
willholley
force-pushed
the
openssh-client
branch
from
bf9f578
to
06127a9
Compare
ssh is only required as a client to connect to external SSH servers. Replacing the use of the openssh apk with openssh-client reduces the surface area of the container and removes a class of vulnerability/configuration warnings that get picked up by static analysis tools in relation to sshd.
willholley
force-pushed
the
openssh-client
branch
from
06127a9
to
d651263
Compare
|
thanks for the swift feedback @stefanprodan - done! |
stefanprodan
approved these changes
Jun 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the primary Flux container,
sshis only required as a client to connect to external SSH servers. Replacing the use of theopensshapk withopenssh-clientreduces the surface area of the container and removes a class of vulnerability/configuration warnings that get picked up by static analysis tools in relation tosshd.