Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Remove the docker runtime and docker-bridge network providers #384

Open
luxas opened this issue Sep 1, 2019 · 8 comments
Open

Remove the docker runtime and docker-bridge network providers #384

luxas opened this issue Sep 1, 2019 · 8 comments
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@luxas
Copy link
Contributor

luxas commented Sep 1, 2019

Fully base Ignite on containerd/CNI-only, and get rid of the extra docker imports.
Will result in a cleaner, leaner and more understandable codebase.
cc @chanwit

@luxas luxas added this to the v0.7.0 milestone Sep 1, 2019
@luxas luxas added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Sep 1, 2019
@chanwit
Copy link
Member

chanwit commented Sep 1, 2019

roger!

@chanwit
Copy link
Member

chanwit commented Sep 4, 2019

@stealthybox what we have planned now conflicts with this issue. could you please remove v0.7.0 milestone out of this one.

@luxas
Copy link
Contributor Author

luxas commented Sep 5, 2019

Why does it conflict? I think we should try to do forward-fixes instead of keeping the older code

@chanwit
Copy link
Member

chanwit commented Sep 5, 2019

the docker runtime makes it a breeze experience for Ignite users but it's still a bit difficult for the containerd runtime to have on-par UX.

If a goal is to have the best UX for people to try VMs with Ignite, let's not too hurry to remove docker :-)

@chanwit
Copy link
Member

chanwit commented Sep 5, 2019

Alternatively, if we could ship containerd along with ignited, and the UX is improved. We could finally remove docker dependency. WDYT? cc @luxas @twelho @stealthybox

ref #399

@stealthybox
Copy link
Contributor

stealthybox commented Sep 11, 2019

I'm less worried about containerd as the runtime now that #411 copes well with different versions and installs.

docker+docker-bridge works OOTB for many users.

docker+cni works except for #393.
containerd+cni is currently not working -- this is our next priority.

Once everything with CNI is fixed and we have packaging and installation polished, I think we can begin to consider this.

It's worth noting that ignite leaves behind a lot of containers right now when we hit bugs managing ignite vm state. This causes ignite to orphan containers and dm snapshots.
The ctr CLI is necessary to clean these up in containerd. ctr is an undocumented, hacky dev tool that is not widely known.

docker has a supported, versioned, CLI, and people know how to use it.

Implementing ignite clean using the containerd API's and dmsetup remove_all would probably be necessary.
As a user I don't know how to manually cleanup after CNI.

@stealthybox
Copy link
Contributor

Adding another CNI issue: #423

@stealthybox
Copy link
Contributor

Also see #436 regarding CNI startup time

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

3 participants