This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
Catch KeyErrors when trying to load manifest #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Wouldn't it be better to report that there is a yaml file which cannot be parsed? I imagine it depends on the situation, but I wouldn't want a mis-match to be silenced just because I had also introduced a formatting error. |
|
@TimJones I think is a good one to implement. Could you please rebase and launch again? Thank you! |
|
@imjoseangel Wow, blast from the past on this one! I've rebased to |
dholbach
reviewed
Oct 4, 2021
dholbach
approved these changes
Oct 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any YAML file is not a Kubernetes object manifest file,
kubedifffails with an exception. This PR allows for processing to continue and the YAML file is simply passed over.