Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/weave-cloud] update image, fix labels #18969

Merged
merged 1 commit into from
Nov 18, 2019
Merged

[stable/weave-cloud] update image, fix labels #18969

merged 1 commit into from
Nov 18, 2019

Conversation

errordeveloper
Copy link
Contributor

What this PR does / why we need it:

Address weaveworks/launcher#303 and update the image.

Which issue this PR fixes

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@errordeveloper
[stable/weave-cloud] update image, fix labels
bfe5f2f 
Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 18, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @errordeveloper. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 18, 2019
@errordeveloper
Copy link
Contributor Author

/assign @stefanprodan

stefanprodan
stefanprodan approved these changes Nov 18, 2019
View reviewed changes
Copy link
Collaborator

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: errordeveloper, stefanprodan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7315c32 into helm:master Nov 18, 2019
JoseAlban pushed a commit to JoseAlban/charts that referenced this pull request Nov 22, 2019
@errordeveloper
[stable/weave-cloud] update image, fix labels (helm#18969)
7c86453 
Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
crmarques pushed a commit to crmarques/charts that referenced this pull request Nov 29, 2019
@errordeveloper
[stable/weave-cloud] update image, fix labels (helm#18969)
461fb3c 
Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
Signed-off-by: Carlos Roberto Marques Junior <carlos.marques@bndes.gov.br>
hakman pushed a commit to hakman/charts that referenced this pull request Dec 5, 2019
@errordeveloper
[stable/weave-cloud] update image, fix labels (helm#18969)
21ce476 
Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
@errordeveloper @dargolith
[stable/weave-cloud] update image, fix labels (helm#18969)
448bbf4 
Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

@cpanato cpanato Awaiting requested review from cpanato

Assignees

@stefanprodan stefanprodan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm chart install is incompatible
4 participants
@errordeveloper @k8s-ci-robot @stefanprodan @helm-bot