Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes logs don't use full width #1977

Closed
errordeveloper opened this issue Nov 4, 2016 · 5 comments
Closed

kubernetes logs don't use full width #1977

errordeveloper opened this issue Nov 4, 2016 · 5 comments
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer k8s Pertains to integration with Kubernetes
Milestone
1.0.0 (kubecon)

Comments

@errordeveloper
Copy link
Contributor

@errordeveloper
Copy link
Contributor Author

If someone could give me pointers, I can attempt to fix it.

@2opremio
Copy link
Contributor

2opremio commented Nov 4, 2016

And ... This is the use case I was referring to in #1966 , should be easy to fix.

@2opremio 2opremio changed the title kubernetes logs don't use full width Implement TTY resizing for attach controls in containers/pods Nov 4, 2016
@2opremio 2opremio added feature Indicates that issue is related to new end user functionality k8s Pertains to integration with Kubernetes labels Nov 4, 2016
@2opremio
Copy link
Contributor

2opremio commented Nov 4, 2016 •
edited

This will slip to the next release though

@2opremio 2opremio added this to the November2016 milestone Nov 4, 2016
@2opremio 2opremio changed the title Implement TTY resizing for attach controls in containers/pods kubernetes logs don't use full width to Implement TTY resizing for attach controls in containers/pods Nov 4, 2016
@2opremio
Copy link
Contributor

2opremio commented Nov 4, 2016 •
edited

And ... This is the use case I was referring to in #1966 , should be easy to fix.

And I am wrong, now that I look at the code, https://github.com/weaveworks/scope/blob/master/probe/kubernetes/controls.go#L41-L43 doesn't use a TTY. It is probably a UI problem since it also happens when attaching containers and I recall they used to fill the full screen.

screen shot 2016-11-04 at 08 57 53

@jpellizzari / @foot Mind taking a look? When the pipe doesn't return tty: raw (example) the pipe output should be able fill the whole terminal without sending any resize requests to the backend (which wouldn't be understood anyways since we are not using a proper TTY).

@2opremio 2opremio added the component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer label Nov 4, 2016
@2opremio
Copy link
Contributor

2opremio commented Nov 4, 2016

A regression in #1966 ?

@2opremio 2opremio modified the milestones: kubecon, November2016 Nov 4, 2016
@2opremio 2opremio added bug Broken end user or developer functionality; not working as the developers intended it and removed feature Indicates that issue is related to new end user functionality labels Nov 4, 2016
@2opremio 2opremio changed the title kubernetes logs don't use full width to Implement TTY resizing for attach controls in containers/pods kubernetes logs don't use full width Nov 4, 2016
@foot foot mentioned this issue Nov 4, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer k8s Pertains to integration with Kubernetes
Projects
None yet
Milestone
1.0.0 (kubecon)
Development

No branches or pull requests
2 participants
@errordeveloper @2opremio