Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic in checkpoint code #1117

Closed
rade opened this issue Mar 4, 2016 · 0 comments
Closed

panic in checkpoint code #1117

rade opened this issue Mar 4, 2016 · 0 comments
Assignees
Labels
bug Broken end user or developer functionality; not working as the developers intended it
Milestone

Comments

@rade
Copy link
Member

rade commented Mar 4, 2016

panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x58 pc=0x4088cc]

goroutine 18 [running]:
main.appMain.func1(0x0, 0x7efcab814868, 0xc821a2ddd0)
        /go/src/github.com/weaveworks/scope/prog/app.go:56 +0x1c
github.com/weaveworks/scope/vendor/github.com/weaveworks/go-checkpoint.CheckInterval.func1(0x13a52453c000, 0xc820273100, 0x198b590, 0xc82034e540)
        /go/src/github.com/weaveworks/scope/vendor/github.com/weaveworks/go-checkpoint/checkpoint.go:208 +0xe7
created by github.com/weaveworks/scope/vendor/github.com/weaveworks/go-checkpoint.CheckInterval
        /go/src/github.com/weaveworks/scope/vendor/github.com/weaveworks/go-checkpoint/checkpoint.go:213 +0xb7

The issue here is that the checkpoint callback can get invoked with a nil first argument and error second argument when something went wrong, yet we pay no attention to the error and immediately dereference the first arg.

@rade rade added the bug Broken end user or developer functionality; not working as the developers intended it label Mar 4, 2016
@rade rade added this to the 0.13.1 milestone Mar 4, 2016
@rade rade mentioned this issue Mar 4, 2016
@tomwilkie tomwilkie self-assigned this Mar 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken end user or developer functionality; not working as the developers intended it
Projects
None yet
Development

No branches or pull requests

2 participants