Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Refresh to Sources and Applications tree view #75

Closed
RandomFractals opened this issue Sep 18, 2021 · 6 comments
Closed

Add Refresh to Sources and Applications tree view #75

RandomFractals opened this issue Sep 18, 2021 · 6 comments
Assignees
Labels
feature New feature request
Projects

Comments

@RandomFractals
Copy link
Collaborator

per our feature review discussion with @murillodigital we'll simply refresh the Sources tree view after flux reconcile command finishes. That might not display the final state of sources, but that's the best we can do with the current CLI driven comms and flux.

@usernamehw that means we'll need to add gitops.views.refreshSources for the selected cluster if we don't already have it. Please create new ticket for that feature, and also add Refresh button to the Sources tree view, so that devs and devOps can refresh source nodes at will.

Originally posted by @RandomFractals in #42 (comment)

@RandomFractals
Copy link
Collaborator Author

RandomFractals commented Sep 19, 2021

@usernamehw btw, all deployments filenames and classes related to the old Deployments tree view should change, as requested in #73.

That should include new refresh commands and tree view context menu options you just added for the Applications view.

@usernamehw
Copy link
Collaborator

@RandomFractals They already should be. You are welcome to check them, since there's a bunch of deployment names unrelated to the rename.

@RandomFractals
Copy link
Collaborator Author

RandomFractals commented Sep 19, 2021

ok. Maybe I was just looking at the stale commit you referenced above: 659b0e4

yep. All good. I see Apps tree view and items in your latest :) https://github.com/weaveworks/vscode-gitops-tools/tree/main/src/views

@RandomFractals
Copy link
Collaborator Author

RandomFractals commented Sep 19, 2021

@usernamehw so, what's remaining to close this?

Please provide screenshots with new Refresh context menus for Clusters, Sources and Apps before you do that.

@usernamehw
Copy link
Collaborator

Screenshot (244)

Sprint 4 automation moved this from In progress to Done Sep 20, 2021
@RandomFractals
Copy link
Collaborator Author

RandomFractals commented Sep 20, 2021

@usernamehw that looks good. btw, looks like you have some custom vscode file icons theme extension you are using.

You should probably disable it while working on this project, so the design screenshots you share match what others would see with normal vscode file icons setup.

All of those tree view nodes should be displaying .yaml file icons with ! after the changes I maid for k8s configs file loading and resourceUri in our tree views.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request
Projects
No open projects
Development

No branches or pull requests

2 participants