-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Refresh to Sources and Applications tree view #75
Comments
@usernamehw btw, all deployments filenames and classes related to the old Deployments tree view should change, as requested in #73. That should include new refresh commands and tree view context menu options you just added for the Applications view. |
@RandomFractals They already should be. You are welcome to check them, since there's a bunch of |
ok. Maybe I was just looking at the stale commit you referenced above: 659b0e4 yep. All good. I see Apps tree view and items in your latest :) https://github.com/weaveworks/vscode-gitops-tools/tree/main/src/views |
@usernamehw so, what's remaining to close this? Please provide screenshots with new Refresh context menus for Clusters, Sources and Apps before you do that. |
@usernamehw that looks good. btw, looks like you have some custom vscode file icons theme extension you are using. You should probably disable it while working on this project, so the design screenshots you share match what others would see with normal vscode file icons setup. All of those tree view nodes should be displaying .yaml file icons with ! after the changes I maid for k8s configs file loading and resourceUri in our tree views. |
per our feature review discussion with @murillodigital we'll simply refresh the Sources tree view after
flux reconcile
command finishes. That might not display the final state of sources, but that's the best we can do with the current CLI driven comms andflux
.@usernamehw that means we'll need to add
gitops.views.refreshSources
for the selected cluster if we don't already have it. Please create new ticket for that feature, and also add Refresh button to the Sources tree view, so that devs and devOps can refresh source nodes at will.Originally posted by @RandomFractals in #42 (comment)
The text was updated successfully, but these errors were encountered: