Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add app --dry-run breaks add app by creating the deploy key #1050

Closed
10 tasks
sympatheticmoose opened this issue Nov 9, 2021 · 0 comments · Fixed by #1054
Closed
10 tasks

add app --dry-run breaks add app by creating the deploy key #1050

sympatheticmoose opened this issue Nov 9, 2021 · 0 comments · Fixed by #1054
Assignees
Labels
bug Something isn't working severity/low low < medium < high < critical

Comments

@sympatheticmoose
Copy link
Contributor

sympatheticmoose commented Nov 9, 2021

Describe the bug
If you run add app twice, first with the dry-run flag to see what should happen, a deploy key will be added to the cluster and then the second add will fail as unable to store secret with the same name.

What is the severity of the bug
Setting as minor for now given expected usage of dry-run... may raise to major.

Environment

  • gitops: [e.g. v0.4.1]
  • kubernetes: [e.g. 1.20.4]
    • [x ] KinD - version]
    • k3s - version
    • cloud [e.g., EKS, AKS] version
    • other - name version
  • Browser + version: [e.g. chrome 74, safari 12, firefox 87]

Affects versions

To Reproduce
Steps to reproduce the behavior:

  1. gitops add app . --dry-run
  2. see: A deploy key named wego-<kubecontext>-<appname> was found on the git provider, but not in the cluster. Deploy key generated and uploaded to git provider
  3. gitops add app .
  4. See error: Error: failed to create app service: error getting git clients: error setting up deploy keys: error storing deploy key: could not store secret: secrets "wego-<kubecontext>-<appname>" already exists

Expected behavior
A drier dry run

Config and Logs
If applicable, add logs to help explain your problem. please compress the output before attaching

  • gitops config
  • gitops cli call output (and parameters)
  • gitops-controller logs
  • Events from wego-* namespaces
  • kubectl cluster-info dump
  • Prometheus alerts
  • Flux logs

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@sympatheticmoose sympatheticmoose added bug Something isn't working severity/low low < medium < high < critical labels Nov 9, 2021
@sympatheticmoose sympatheticmoose changed the title add app --dry run breaks add app by creating the deploy key add app --dry-run breaks add app by creating the deploy key Nov 9, 2021
@josecordaz josecordaz self-assigned this Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working severity/low low < medium < high < critical
Projects
None yet
2 participants