Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky unit test #1199

Closed
JamWils opened this issue Dec 8, 2021 · 2 comments · Fixed by #1314 or #1358
Closed

Fix flaky unit test #1199

JamWils opened this issue Dec 8, 2021 · 2 comments · Fixed by #1314 or #1358
Assignees
Labels
bug Something isn't working type/story

Comments

@JamWils
Copy link
Contributor

JamWils commented Dec 8, 2021

The unit test below fails intermittently on our CI pipeline. This is causing a lot of unnecessary delays. Fix the unit test so it is no longer flaky.

• Failure [0.003 seconds]
Github Device Flow
/home/runner/work/***/***/pkg/services/auth/github_test.go:40
  pollAuthStatus
  /home/runner/work/***/***/pkg/services/auth/github_test.go:92
    returns a token after a slow_down [It]
    /home/runner/work/***/***/pkg/services/auth/github_test.go:118

    should have tried the first time
    Expected
        <int>: 0
    to equal
        <int>: 1

    /home/runner/work/***/***/pkg/services/auth/github_test.go:133
@J-Thompson12
Copy link
Contributor

I am still getting this issue in the pipeline

Github Device Flow
/home/runner/work/***/***/pkg/services/auth/github_test.go:41
  pollAuthStatus
  /home/runner/work/***/***/pkg/services/auth/github_test.go:93
    returns a token after a slow_down [It]
    /home/runner/work/***/***/pkg/services/auth/github_test.go:119

    should have tried the first time
    Expected
        <int>: 0
    to equal
        <int>: 1

    /home/runner/work/***/***/pkg/services/auth/github_test.go:135

@J-Thompson12 J-Thompson12 reopened this Jan 24, 2022
@J-Thompson12
Copy link
Contributor

We need to find a new package to handle this or code up our own solution. The current package isnt working how we want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working type/story
Projects
None yet
4 participants