Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The user should be able to specify the external config repo branch #380

Closed
5 tasks
luizbafilho opened this issue Jun 23, 2021 · 3 comments
Closed
5 tasks

Comments

@luizbafilho
Copy link
Contributor

luizbafilho commented Jun 23, 2021

Short description
As a User I want to be able to specify the external repo branch.

If the app repo and the config repo have different default branches currently wego breaks because it will use whatever was specified for the app repo. ie: you app repo uses main your config repo uses master.

We currently already check the default branch of the external config repo.

Users will want to open a PR to a specific topic or environment branch.

Acceptance criteria

  • the user can have the app repo and the config repo with different branch
  • the add command accepts the --app-config-branch

Design materials

  • Screenshots
  • Design diagrams
  • WEP
  • PR/FAQ

Work breakdown
(optional)Task breakdown of the work

  • create X
  • design X
  • ...
@jpellizzari
Copy link
Contributor

@luizbafilho Please fill out why a user would want to do this and what benefit they would get from this feature.

@luizbafilho
Copy link
Contributor Author

if the app repo and the config repo have different default branches currently wego breaks because it will use whatever was specified for the app repo. ie: you app repo uses main your config repo uses master

@jpellizzari
Copy link
Contributor

New directory structure work might negate this as a valid feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants