Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add a CI to detect duplicate dependencies #4714

Closed
chenjiahan opened this issue Sep 22, 2023 · 5 comments · Fixed by #4985
Closed

[Feature]: Add a CI to detect duplicate dependencies #4714

chenjiahan opened this issue Sep 22, 2023 · 5 comments · Fixed by #4985
Labels

Comments

@chenjiahan
Copy link
Member

What problem does this feature solve?

Related issue: #494

What does the proposed API look like?

If we can add a CI to detect duplicate dependencies, it will help us to unify the version of 3rd party dependencies and reduce duplicate dependencies.

@tunahan-guler
Copy link

bro how can we reduce duplicate dependencies now?

@chenjiahan
Copy link
Member Author

@tunahan-guler This issue is about the duplicate package problem in this modern.js repository.

Can you describe the problem you are currently facing?

@tunahan-guler
Copy link

@chenjiahan I use my own library in my main project and subproject. I didn't add these as shared. I wonder if this will cause a problem.

@chenjiahan
Copy link
Member Author

I understand that your topic may not be in line with our current discussion. To manage shared dependencies, you should take care of this aspect yourself. You can explore options such as the pnpm workspace or any other suitable alternative.

@chenjiahan
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants