-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should not generate facade .js
files for CSS chunks
#3608
Comments
Thanks for reporting. I'd like to take a look at this. Please provide a reproduction repo using https://github.com/web-infra-dev/rspack-repro. |
@hyf0 https://github.com/ICJR/rspack-repro I noticed the empty Side question: In the previous version of rspack if I used |
See details at https://www.rspack.dev/blog/announcing-0.2.html#breaking-changes and #3270. |
Is this file the empty file that you refer to? If it is, the js file is generated expectedly under the current CSS implementation of Rspack. Webpack won't emit the js file. It's a known difference and we plan to align with Webpack in the future. |
That's the correct file, is my only option to revert to the older rspack version in the meantime? |
I'm not sure how the old version behaves. But the current behavior is expected and correct. My suggestion is to use the current version. It's not a bug. I won't close this issue now. As I said before, we will align our CSS implementation with Webpack5 in the near future, then it will solve this issue. |
.js
files for CSS chunks
This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment! |
@hyf0 is this fixed? |
This is a alignment feature rather than a bug. The alignment hasn't been made. |
This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment! |
System Info
System:
OS: Windows 10 10.0.19045
CPU: (12) x64 Intel(R) Core(TM) i7
Memory: 20.73 GB / 31.91 GB
Binaries:
Node: 18.12.0 - C:\Program Files\n
npm: 9.2.0 - C:\Program Files\node
Browsers:
Edge: Spartan (44.19041.1266.0), C
Internet Explorer: 11.0.19041.1566
Details
output.filename
no longer supporting[ext]
filename
,cssFilename
, etc.Reproduce link
No response
Reproduce Steps
Bundle sass files using
0.2.3
The text was updated successfully, but these errors were encountered: