Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include the benchmark results in the comments of every pr #5122

Closed
bvanjoi opened this issue Dec 26, 2023 · 1 comment · Fixed by #5170
Closed

Include the benchmark results in the comments of every pr #5122

bvanjoi opened this issue Dec 26, 2023 · 1 comment · Fixed by #5170
Assignees
@jerrykingxyz
Labels
feat New feature or request team The issue/pr is created by the member of Rspack.

Comments

@bvanjoi
Copy link
Collaborator

bvanjoi commented Dec 26, 2023

What problem does this feature solve?

nothing

What does the proposed API of configuration look like?

nothing
@bvanjoi bvanjoi added feat New feature or request pending triage The issue/PR is currently untouched. labels Dec 26, 2023
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Dec 26, 2023
@jerrykingxyz
Copy link
Collaborator

Good idea, i wll try it.

@jerrykingxyz jerrykingxyz removed the pending triage The issue/PR is currently untouched. label Dec 29, 2023
@jerrykingxyz jerrykingxyz self-assigned this Dec 29, 2023
@jerrykingxyz jerrykingxyz linked a pull request Jan 2, 2024 that will close this issue
chore: comment benchmark result for commit #5170
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jerrykingxyz jerrykingxyz

Labels
feat New feature or request team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: comment benchmark result for commit web-infra-dev/rspack
2 participants
@jerrykingxyz @bvanjoi