Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] pinyin-pro minify error #6488

Closed
LingyuCoder opened this issue May 9, 2024 · 1 comment
Closed

[bug] pinyin-pro minify error #6488

LingyuCoder opened this issue May 9, 2024 · 1 comment
Labels
team The issue/pr is created by the member of Rspack.

Comments

@LingyuCoder
Copy link
Collaborator

while minimize with builtin swc minimizier which use swc_core@0.90.31, the minimized code of pinyin-pro cannot run correctly.

For example, "me mó ma yāo" will be convert to "me m\xf3 ma yāo" (playground).

This bug has been fixed by swc_core@0.90.37 by swc-project/swc#8873 (playground). So Rspack should upgrade swc_core to solve this issue
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 9, 2024
@LingyuCoder LingyuCoder mentioned this issue May 9, 2024
Merged
2 tasks
@LingyuCoder
Copy link
Collaborator Author

fixed by #6441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LingyuCoder