Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font-size-adjust #541

Closed
2 of 3 tasks
firefoxic opened this issue Oct 4, 2023 · 10 comments
Closed
2 of 3 tasks

font-size-adjust #541

firefoxic opened this issue Oct 4, 2023 · 10 comments
Labels
focus-area-proposal Focus Area Proposal

Comments

@firefoxic
Copy link

Description

The font-size-adjust property allows you to make different fonts the same visual size. This is useful when replacing a local font with a custom font, or when different fonts are adjacent on the same line.

Specification

https://www.w3.org/TR/css-fonts-3/#font-size-adjust-prop

Open Issues

No response

Tests

https://wpt.fyi/results/css/css-fonts?label=experimental&label=master&aligned=&q=font-size-adjust

Current Implementations

  • Blink
  • Gecko
  • WebKit

Standards Positions

No response

Browser bug reports

https://crbug.com/451346
https://crbug.com/1219875

Developer discussions

No response

Polls & Surveys

No response

Existing Usage

No response

Workarounds

No response

Accessibility Impact

No response

Privacy Impact

No response

Other

https://developer.mozilla.org/en-US/docs/Web/CSS/font-size-adjust
https://caniuse.com/font-size-adjust

@firefoxic firefoxic added the focus-area-proposal Focus Area Proposal label Oct 4, 2023
@jensimmons
Copy link
Contributor

jensimmons commented Oct 5, 2023

This would be a great thing to add to Interop 2024. We should be sure to include all three parts:

  • basic support for font-sizeadjust`
  • support for the from-font keyword
  • support for two value syntax (which allows the developer to size according to another metric, not just x-height)
Screenshot 2023-10-05 at 6 38 06 PM

The tests are not working correctly if Chrome has not yet added support for font-size-adjust, but passes 88.8% of the tests.... so we need to take a look at the tests.

@dbaron
Copy link
Member

dbaron commented Oct 6, 2023

You should see drastically different test results between:
https://wpt.fyi/results/css/css-fonts?label=experimental&label=master&q=font-size-adjust (which tests Chrome dev channel, with --enable-experimental-web-platform-features) and https://wpt.fyi/results/css/css-fonts?label=master&label=stable&q=font-size-adjust (which tests Chrome stable channel).

@jensimmons
Copy link
Contributor

Ah, that makes sense. Great news.

That means the current experiment scores are:
Chrome Dev: 88.8%
Firefox Nightly: 100%
Safari Technology Preview: 98.5%

There's a chance the scores will be too high to make sense to consider for Interop 2024 — that we have interop before the year starts.

@firefoxic
Copy link
Author

I am skeptical about this. After all, Chrome has had this property behind the flag for years. And I have no hope at all that this will change. My only hope is Interop ❤️

@kojiishi
Copy link

kojiishi commented Oct 6, 2023

This is a recent progress, please see crbug.com/1219875. @shivamidow @drott

@shivamidow
Copy link

I have pushed font-size-adjust to both Blink and WebKit this year. All necessary pieces are in the review pipeline, so Blink and WebKit will hit 100% soon.

Blink:

WebKit:

@firefoxic
Copy link
Author

Is there similarly positive news regarding size-adjust #542 ?

@drott
Copy link

drott commented Oct 23, 2023

In the process, we should try to get a resolution on w3c/csswg-drafts#8967 CC @svgeesus

@jensimmons
Copy link
Contributor

The proposed test set includes font-size-adjust-metrics-override.html — which requires support for ascent-override / descent-override, a feature WebKit does not yet support. We'd like this test to not be included, since it's an 'off topic dependency'.

@zcorpan
Copy link
Member

zcorpan commented Feb 1, 2024

Thank you for proposing font-size-adjust for inclusion in Interop 2024.

We are pleased to let you know that this proposal was accepted as part of the font-size-adjust focus area. You can follow the progress of this focus area on the Interop 2024 dashboard.

For an overview of our process, see the proposal selection. Thank you for contributing to Interop 2024!

Posted on behalf of the Interop team.

@zcorpan zcorpan closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus-area-proposal Focus Area Proposal
Projects
Status: Done
Development

No branches or pull requests

7 participants