Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement retry when failing to write to GCS #1161

Open
foolip opened this issue Feb 20, 2019 · 4 comments
Open

Implement retry when failing to write to GCS #1161

foolip opened this issue Feb 20, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@foolip
Copy link
Member

foolip commented Feb 20, 2019

Check

A link to the GitHub Check run containing my issue:
https://github.com/web-platform-tests/wpt/pull/15475/checks

Description

There are checks for staging.wpt.fyi, but none for wpt.fyi.

@foolip foolip added the bug Something isn't working label Feb 20, 2019
@foolip foolip added this to To do in Regression Detection via automation Feb 20, 2019
@foolip
Copy link
Member Author

foolip commented Feb 20, 2019

The runs were ingested: https://wpt.fyi/results/?sha=ed55be4

@lukebjerring
Copy link
Contributor

In AppEngine > Services > default > Logs

API error: HTTP 500: error(s) occured when transferring results from azure to GCS:
Post https://www.googleapis.com/upload/storage/v1/b/wptd-results-buffer/o?alt=json&projection=full&uploadType=multipart: API error 1 (urlfetch: INVALID_URL)

FYI @Hexcles . Not sure if is this a transient error or not - more inspection required.

@Hexcles
Copy link
Member

Hexcles commented Feb 20, 2019

It is. I've seen this error occasionally. We don't directly post to GCS using urlfetch; this is done by the appengine GCS library internally which we have no control over. We might need some retry mechanism, but I'm not sure yet which part we need to retry (Write, Close, or both).

@foolip
Copy link
Member Author

foolip commented Feb 27, 2019

I have no results on web-platform-tests/wpt#15577 either. Possibly they're still in the pipeline, we'll see. What's the expected delay?

@lukebjerring lukebjerring changed the title No checks for wpt.fyi Implement retry when failing to write to GCS Mar 4, 2019
@lukebjerring lukebjerring added enhancement New feature or request and removed bug Something isn't working labels Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

3 participants