-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't include "status check" in the name of the check suite #1557
Comments
This fix for this would be in https://github.com/organizations/web-platform-tests/settings/apps: @Hexcles @stephenmcgruer what name would you like? |
So the responsibilities for the task: add results to the datastore backing wpt.fyi, and report regressions? Hard to summarize, I'd be happy with just 'wpt.fyi' to match 'Azure Pipelines'. But really I don't care that much :p |
It actually isn't responsible for getting any results into wpt.fyi, the check just compares the results. On PRs it compares the results with and without the changes and also links to diffs to master, and on commits to master the check compares to the previous master run. Just "wpt.fyi" would be fine I think. @Hexcles? |
Yeah it says that but it’s not really the responsibility of the check, it would happen anyway and did work the same before the check existed. It would be fine to make the check represent the results processor as well if there’s some utility to it. @Hexcles WDYT? |
The name is in fact configured on GitHub settings. I've changed the names to remove "status check" for both installations. I'll look into other feature requests separately. Some of them seem to be related to lifecycle. |
Check
https://github.com/web-platform-tests/wpt/pull/10571/checks?check_run_id=268068852 or any other check
Description
The check suite is named "wpt.fyi status check" (or "staging.wpt.fyi status check") and especially the word "check" isn't useful to have there.
My suggestions would be just "wpt.fyi" or perhaps "wpt.fyi results".
The text was updated successfully, but these errors were encountered: