Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compat2021] Link to wpt.fyi run at the point of the graph #2531

Open
foolip opened this issue May 13, 2021 · 3 comments
Open

[compat2021] Link to wpt.fyi run at the point of the graph #2531

foolip opened this issue May 13, 2021 · 3 comments
Labels
interop Issues with the Interop dashboards

Comments

@foolip
Copy link
Member

foolip commented May 13, 2021

On https://wpt.fyi/compat2021?feature=position-sticky, clicking a point in the graph will show a "show browser changelog" link. It would be very useful to also have a list to the wpt.fyi run which is being that point in the graph, and maybe a diff against the previous run.

This would make it easier to figure out why regressions have happened, as in the What is causing the score reduction for position:sticky? thread.

@foolip
Copy link
Member Author

foolip commented May 13, 2021

@stephenmcgruer do you think this would be easy to fix?

@stephenmcgruer
Copy link
Contributor

Annoyingly not trivial, because I dropped the sha from the new unified csv file.

You'd need to:

  1. Add it to the csv file generated here: https://github.com/Ecosystem-Infra/wpt-results-analysis/blob/main/compat-2021/main.js#L390
  2. Create a sha list here, similar to browserVersions - https://github.com/web-platform-tests/wpt.fyi/blob/main/webapp/components/compat-2021.js#L87
  3. Modify this tooltip action to use the new shas list - https://github.com/web-platform-tests/wpt.fyi/blob/main/webapp/components/compat-2021.js#L682

The most annoying bit will be not breaking wpt.fyi when you add the SHAs to the csv file (yay csv files... wish I'd used JSON?)

@foolip
Copy link
Member Author

foolip commented May 14, 2021

Thanks Stephen! Seems doable but not trivial then :)

@gsnedders gsnedders added the interop Issues with the Interop dashboards label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interop Issues with the Interop dashboards
Projects
None yet
Development

No branches or pull requests

3 participants