-
Notifications
You must be signed in to change notification settings - Fork 3k
/
popover-focus.tentative.html
348 lines (323 loc) · 15.6 KB
/
popover-focus.tentative.html
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
<!DOCTYPE html>
<meta charset="utf-8" />
<title>Popover focus behaviors</title>
<link rel="author" href="mailto:masonf@chromium.org">
<link rel=help href="https://open-ui.org/components/popover.research.explainer">
<meta name="timeout" content="long">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-actions.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
<script src="resources/popover-utils.js"></script>
<div popover data-test='default behavior - popover is not focused' data-no-focus>
<p>This is a popover</p>
<button>first button</button>
</div>
<div popover data-test='autofocus popover' autofocus tabindex=-1 class=should-be-focused>
<p>This is a popover</p>
</div>
<div popover data-test='autofocus empty popover' autofocus tabindex=-1 class=should-be-focused></div>
<div popover data-test='autofocus popover with button' autofocus tabindex=-1 class=should-be-focused>
<p>This is a popover</p>
<button>button</button>
</div>
<div popover data-test='autofocus child'>
<p>This is a popover</p>
<button autofocus class=should-be-focused>autofocus button</button>
</div>
<div popover data-test='autofocus on tabindex=0 element'>
<p autofocus tabindex=0 class=should-be-focused>This is a popover with autofocus on a tabindex=0 element</p>
<button>button</button>
</div>
<div popover data-test='autofocus multiple children'>
<p>This is a popover</p>
<button autofocus class=should-be-focused>autofocus button</button>
<button autofocus>second autofocus button</button>
</div>
<div popover autofocus tabindex=-1 data-test='autofocus popover and multiple autofocus children' class=should-be-focused>
<p>This is a popover</p>
<button autofocus>autofocus button</button>
<button autofocus>second autofocus button</button>
</div>
<style>
[popover] {
border: 2px solid black;
top:150px;
left:150px;
opacity: 0;
}
[popover]:not(:open) {
/* Add a *hide* transition to all popovers, to make sure animations don't
affect focus management */
transition: opacity 10s;
}
[popover]:open {
opacity: 1;
}
:focus-within { border: 5px dashed red; }
:focus { border: 5px solid lime; }
</style>
<script>
function addInvoker(t, popover) {
const button = document.createElement('button');
button.innerText = 'Click me';
const popoverId = 'popover-id';
assert_equals(document.querySelectorAll('#' + popoverId).length, 0);
document.body.appendChild(button);
t.add_cleanup(function() {
popover.removeAttribute('id');
button.remove();
});
popover.id = popoverId;
button.setAttribute('popovertoggletarget', popoverId);
return button;
}
function addPriorFocus(t) {
const priorFocus = document.createElement('button');
priorFocus.id = 'priorFocus';
document.body.appendChild(priorFocus);
t.add_cleanup(() => priorFocus.remove());
return priorFocus;
}
async function finishAnimationsAndVerifyHide(popover) {
await finishAnimations(popover);
assert_false(isElementVisible(popover),'After animations are finished, the popover should be hidden');
}
function activateAndVerify(popover) {
const testName = popover.getAttribute('data-test');
promise_test(async t => {
const priorFocus = addPriorFocus(t);
let expectedFocusedElement = popover.matches('.should-be-focused') ? popover : popover.querySelector('.should-be-focused');
const changesFocus = !popover.hasAttribute('data-no-focus');
if (!changesFocus) {
expectedFocusedElement = priorFocus;
}
assert_true(!!expectedFocusedElement);
assert_false(popover.matches(':open'));
// Directly show and hide the popover:
priorFocus.focus();
assert_equals(document.activeElement, priorFocus);
popover.showPopover();
assert_equals(document.activeElement, expectedFocusedElement, `${testName} activated by popover.showPopover()`);
popover.hidePopover();
assert_equals(document.activeElement, priorFocus, 'prior element should get focus on hide, or if focus didn\'t shift on show, focus should stay where it was');
await finishAnimationsAndVerifyHide(popover);
// Hit Escape:
priorFocus.focus();
assert_equals(document.activeElement, priorFocus);
popover.showPopover();
assert_equals(document.activeElement, expectedFocusedElement, `${testName} activated by popover.showPopover()`);
await sendEscape();
assert_equals(document.activeElement, priorFocus, 'prior element should get focus after Escape');
await finishAnimationsAndVerifyHide(popover);
// Change the popover type:
priorFocus.focus();
popover.showPopover();
assert_equals(document.activeElement, expectedFocusedElement, `${testName} activated by popover.showPopover()`);
assert_equals(popover.popover, 'auto', 'All popovers in this test should start as popover=auto');
popover.popover = 'hint';
assert_false(popover.matches(':open'), 'Changing the popover type should hide the popover');
assert_equals(document.activeElement, priorFocus, 'prior element should get focus when the type is changed');
await finishAnimationsAndVerifyHide(popover);
popover.popover = 'auto';
// Remove from the document:
priorFocus.focus();
popover.showPopover();
assert_equals(document.activeElement, expectedFocusedElement, `${testName} activated by popover.showPopover()`);
popover.remove();
assert_false(isElementVisible(popover), 'Removing the popover should hide it immediately');
if (!popover.hasAttribute('data-no-focus')) {
assert_not_equals(document.activeElement, priorFocus, 'prior element should *not* get focus when the popover is removed from the document');
}
document.body.appendChild(popover);
// Show a modal dialog:
priorFocus.focus();
popover.showPopover();
assert_equals(document.activeElement, expectedFocusedElement, `${testName} activated by popover.showPopover()`);
const dialog = document.body.appendChild(document.createElement('dialog'));
dialog.showModal();
assert_false(isElementVisible(popover), 'Opening a modal dialog should hide the popover immediately');
assert_not_equals(document.activeElement, priorFocus, 'prior element should *not* get focus when a modal dialog is shown');
dialog.close();
dialog.remove();
// Use an activating element:
const button = addInvoker(t, popover);
priorFocus.focus();
button.click();
assert_true(popover.matches(':open'));
assert_equals(document.activeElement, expectedFocusedElement, `${testName} activated by button.click()`);
// Make sure we can directly focus the (already open) popover:
popover.focus();
assert_equals(document.activeElement, popover.hasAttribute('tabindex') ? popover : expectedFocusedElement, `${testName} directly focus with popover.focus()`);
button.click(); // Button is set to toggle the popover
assert_false(popover.matches(':open'));
assert_equals(document.activeElement, priorFocus, 'prior element should get focus on button-toggled hide');
await finishAnimationsAndVerifyHide(popover);
}, "Popover focus test: " + testName);
promise_test(async t => {
const priorFocus = addPriorFocus(t);
assert_false(popover.matches(':open'), 'popover should start out hidden');
let button = addInvoker(t, popover);
assert_equals(button.getAttribute('popovertoggletarget'), popover.id, 'This test assumes the button uses `popovertoggletarget`.');
assert_not_equals(button, priorFocus, 'Stranger things have happened');
assert_false(popover.contains(button), 'Start with a non-contained button');
priorFocus.focus();
assert_equals(document.activeElement, priorFocus);
popover.showPopover();
assert_true(popover.matches(':open'));
await clickOn(button); // This will *not* light dismiss, but will "toggle" the popover.
assert_false(popover.matches(':open'));
const changesFocus = !popover.hasAttribute('data-no-focus');
if (changesFocus)
assert_equals(document.activeElement, priorFocus, 'focus should return to the prior focus, if focus moved on show');
else
assert_equals(document.activeElement, button, 'focus should remain on the button, since focus didn\t move on show');
await finishAnimationsAndVerifyHide(popover);
// Same thing, but the button is contained within the popover
button.removeAttribute('popovertoggletarget');
button.setAttribute('popoverhidetarget', popover.id);
popover.appendChild(button);
t.add_cleanup(() => button.remove());
priorFocus.focus();
popover.showPopover();
assert_true(popover.matches(':open'));
if (changesFocus) {
assert_not_equals(document.activeElement, priorFocus, 'focus should shift for this element');
}
await clickOn(button);
assert_false(popover.matches(':open'), 'clicking button should hide the popover');
if (changesFocus) {
assert_equals(document.activeElement, priorFocus, 'Contained button should return focus to the previously focused element, if focus moved on show');
}
await finishAnimationsAndVerifyHide(popover);
// Same thing, but the button is unrelated (no popovertoggletarget)
button = document.createElement('button');
document.body.appendChild(button);
priorFocus.focus();
popover.showPopover();
assert_true(popover.matches(':open'));
await clickOn(button); // This will light dismiss the popover, focus the prior focus, then focus this button.
assert_false(popover.matches(':open'), 'clicking button should hide the popover (via light dismiss)');
assert_equals(document.activeElement, button, 'Focus should go to unrelated button on light dismiss');
await finishAnimationsAndVerifyHide(popover);
}, "Popover button click focus test: " + testName);
promise_test(async t => {
if (popover.hasAttribute('data-no-focus')) {
// This test only applies if the popover changes focus
return;
}
const priorFocus = addPriorFocus(t);
assert_false(popover.matches(':open'), 'popover should start out hidden');
// Move the prior focus out of the document
priorFocus.focus();
popover.showPopover();
assert_true(popover.matches(':open'));
const newFocus = document.activeElement;
assert_not_equals(newFocus, priorFocus, 'focus should shift for this element');
priorFocus.remove();
assert_equals(document.activeElement, newFocus, 'focus should not change when prior focus is removed');
popover.hidePopover();
assert_not_equals(document.activeElement, priorFocus, 'focused element has been removed');
await finishAnimationsAndVerifyHide(popover);
document.body.appendChild(priorFocus); // Put it back
// Move the prior focus inside the (already open) popover
priorFocus.focus();
popover.showPopover();
assert_true(popover.matches(':open'));
assert_false(popover.contains(priorFocus), 'Start with a non-contained prior focus');
popover.appendChild(priorFocus); // Move inside the popover
assert_true(popover.contains(priorFocus));
assert_true(popover.matches(':open'), 'popover should stay open');
popover.hidePopover();
await waitForRender();
assert_true(isElementVisible(popover),'Animations should keep the popover visible');
assert_not_equals(getComputedStyle(popover).display,'none','Animations should keep the popover visible');
assert_equals(document.activeElement, priorFocus, 'focused element gets focused');
await finishAnimationsAndVerifyHide(popover);
assert_equals(getComputedStyle(popover).display,'none','Animations have ended, popover should be hidden');
assert_not_equals(document.activeElement, priorFocus, 'focused element is display:none inside the popover');
document.body.appendChild(priorFocus); // Put it back
}, "Popover corner cases test: " + testName);
}
document.querySelectorAll('body > [popover]').forEach(popover => activateAndVerify(popover));
</script>
<div id=fixup>
<button id=button1>Button1</button>
<div popover id=popover1 style="top:100px">
<button id=inside_popover1>Inside1</button>
<button id=invoker2 popovertoggletarget=popover2>Nested Invoker 2</button>
<button id=inside_popover2>Inside2</button>
</div>
<button id=button2>Button2</button>
<button popovertoggletarget=popover1 id=invoker1>Invoker1</button>
<button id=button3>Button3</button>
<div popover id=popover2 style="top:200px">
<button id=inside_popover3>Inside3</button>
<button id=invoker3 popovertoggletarget=popover3>Nested Invoker 3</button>
</div>
<div popover id=popover3 style="top:300px">
Non-focusable popover
</div>
<button id=button4>Button4</button>
</div>
<style>
#fixup [popover] {
bottom:auto;
}
</style>
<script>
async function verifyFocusOrder(order) {
order[0].focus();
for(let i=0;i<order.length;++i) {
const control = order[i];
assert_equals(document.activeElement,control,`Step ${i+1}`);
await sendTab();
}
// Shift-tab not supported, crbug.com/893480.
// for(let i=order.length-1;i>=0;--i) {
// const control = order[i];
// await sendShiftTab();
// assert_equals(document.activeElement,control,`Step ${i+1} (backwards)`);
// }
}
promise_test(async t => {
button1.focus();
assert_equals(document.activeElement,button1);
await sendTab();
assert_equals(document.activeElement,button2,'Hidden popover should be skipped');
// Shift-tab not supported, crbug.com/893480.
// await sendShiftTab();
// assert_equals(document.activeElement,button1,'Hidden popover should be skipped backwards');
//await sendTab();
await sendTab();
assert_equals(document.activeElement,invoker1);
await sendEnter(); // Activate the invoker
assert_true(popover1.matches(':open'), 'popover1 should be invoked by invoker1');
assert_equals(document.activeElement,invoker1,'Focus should not move when popover is shown');
await sendTab();
assert_equals(document.activeElement,inside_popover1,'Focus should move from invoker into the open popover');
await sendTab();
assert_equals(document.activeElement,invoker2,'Focus should move within popover');
await verifyFocusOrder([button1, button2, invoker1, inside_popover1, invoker2, inside_popover2, button3, button4]);
invoker2.focus();
await sendEnter(); // Activate the nested invoker
assert_true(popover2.matches(':open'), 'popover2 should be invoked by nested invoker');
assert_equals(document.activeElement,invoker2,'Focus should stay on the invoker');
await sendTab();
assert_equals(document.activeElement,inside_popover3,'Focus should move into nested popover');
await sendTab();
assert_equals(document.activeElement,invoker3);
await sendEnter(); // Activate the (empty) nested invoker
assert_true(popover3.matches(':open'), 'popover3 should be invoked by nested invoker');
assert_equals(document.activeElement,invoker3,'Focus should stay on the invoker');
await sendTab();
assert_equals(document.activeElement,inside_popover2,'Focus should skip popover without focusable content, going back to higher scope');
await sendTab();
assert_equals(document.activeElement,button3,'Focus should exit popovers');
await sendTab();
assert_equals(document.activeElement,button4,'Focus should skip popovers');
button1.focus();
await verifyFocusOrder([button1, button2, invoker1, inside_popover1, invoker2, inside_popover3, invoker3, inside_popover2, button3, button4]);
}, "Popover focus navigation");
</script>