Update the performance-timeline IDL file + test #11911
Conversation
…kebjerring/web-platform-tests into idl-file-updates-performance-timeline
wpt-pr-bot
requested review from
igrigorik,
jensl,
plehegar,
toddreifsteck and
yuki3
| idl_array.add_objects({ | ||
| Performance: ['performance'], | ||
| // PerformanceEntry implicitly tested in user-timing. | ||
| ResizeObserverEntry: ['observerEntry'], |
There was a problem hiding this comment.
@npm1 - I'd like to cover PerformanceObserverEntryList but I'm not sure where to get an instance.
Am I missing something, or is it the same method set as PerformanceEntryList, so probably implemented by Performance, but not stated as such in the IDL?
There was a problem hiding this comment.
PerformanceObserverEntryList is the first parameter that a callback to the PerformanceObserver receives. So you can get such an object by creating a PerformanceObserver and calling observe().
It is not quite the same as PerformanceEntryList. PerformanceObserverEntryList is a wrapper interface that allows calling getEntries() and a couple other methods, whose return values are a sequence of entries, i.e. a PerformanceEntryList.
There was a problem hiding this comment.
@lukebjerring is this PR blocked on the above, or?
|
No, the above can be included in a follow up PR! |
Hello reviewer(s),
This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.
The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.
This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.
Please check that:
The spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the
interfaces/directory (instead of inline copies in the test files).