[css-contain] Add support file in local directory #12492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewilligers
approved these changes
Aug 15, 2018
|
I'm not sure this is actually useful as the test still uses an absolute path Apart from that, the issue with this particular test has been fixed in #12371 by serving that folder. Should we revert this change? |
|
I think the path was to the relative file when I made this patch, so maybe another fix went in parallel, making this one useless. Or maybe I was just not paying attention :) Either way, yes, we can revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very annoying that we have to keep on replicating the support files all around, but for now, given how the build system works, we do have to.
I'll be the first to be happy when this annoyance is solved, but until it is, we still need functional tests.
http://test.csswg.org/suites/css-contain-1_dev/nightly-unstable/html/contain-size-013.htm needs this file.