Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lh-rlh-on-root-001.html : 3 corrections to make #14160

Closed
TalbotG opened this issue Nov 21, 2018 · 2 comments
Closed

lh-rlh-on-root-001.html : 3 corrections to make #14160

TalbotG opened this issue Nov 21, 2018 · 2 comments

Comments

@TalbotG
Copy link
Contributor

TalbotG commented Nov 21, 2018

@frivoal

The 3 corrections to make are emboldened.

line 48 is:
assert_approx_equals( f_s, initial_f_s, 1, "the lh unit on the root element's font-size property uses font metrics corresponding to the initial values of the font or line-height properties");

line 48 should be instead:
assert_approx_equals( f_s, initial_l_h, 1, "the lh unit on the root element's font-size property uses font metrics corresponding to the initial values of the font or line-height properties");


line 54 is:
assert_approx_equals( f_s, initial_f_s, 1, "the rlh unit on the root element's font-size property uses font metrics corresponding to the initial values of the font or line-height properties");

line 54 should be instead:
assert_approx_equals( f_s, initial_l_h, 1, "the rlh unit on the root element's font-size property uses font metrics corresponding to the initial values of the font or line-height properties");


line 74 is:
assert_approx_equals( f_s, initial_f_s * 2, 1, "the lh unit on the root element's font-size property actually works as a unit and doesn't merely cause a fallback that doesn't take the number of units into account");

lin 74 should be instead:
assert_approx_equals( f_s, initial_l_h * 2, 1, "the lh unit on the root element's font-size property actually works as a unit and doesn't merely cause a fallback that doesn't take the number of units into account");

@TalbotG
Copy link
Contributor Author

TalbotG commented Jan 24, 2019

#15030

@frivoal
Copy link
Contributor

frivoal commented Feb 5, 2019

Fixed by #15030

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants