Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to Add @anonrig and @lemire as Collaborators to WPT Project #43580

Closed
nomadtechie opened this issue Dec 8, 2023 · 5 comments
Closed
Assignees

Comments

@nomadtechie
Copy link
Member

Hello folks,

I'd like to request that we add @anonrig and @lemire as collaborators to the Web Platform Tests (WPT) project. Both individuals are Node.js collaborators, while Yagiz is also a member of the Node.js Technical Steering committee. They are also co-authors, and maintainers of the widely used Ada URL parser project (https://github.com/ada-url/ada). Ada is a WHATWG spec-compliant URL parser that is not only utilized in Node.js but also adaptable for non-JavaScript server runtimes such as Rust and Python, for example https://github.com/ada-url/ada-python and https://github.com/ada-url/rust.

Yagiz and Daniel currently maintain an automated workflow for pulling in relevant WPT tests into the Ada project, see a recent upstream merge example here.

Both contributors have not only identified and reported bugs in existing tests but have also made substantial contributions to the Web Platform Tests repository. An exemplary contribution includes additional tests and fixes for issues within pre-existing tests, all stemming from their work on the Ada project.

Adding them as contributors to WPT formally would be a great step towards furthering more initiatives like Ada which enable interoperability and spec compliance for NodeJS, as Ada is now one of the consumers for WPT.

I spoke with @zcorpan about this offline on Nov 30th 2023, and he said next steps would be to file a public issue. 😃

Looking forward to seeing them both added as official contributors to this incredible project.

Best,
Amal Hussein

@zcorpan
Copy link
Member

zcorpan commented Dec 12, 2023

SGTM, I can invite them to the reviewers team. Thanks, and welcome!

fyi @web-platform-tests/admins

@zcorpan
Copy link
Member

zcorpan commented Dec 12, 2023

Done, https://github.com/orgs/web-platform-tests/teams/reviewers

@anonrig, @lemire, you need to accept the invitation to the org.

@zcorpan zcorpan closed this as completed Dec 12, 2023
@anonrig
Copy link
Member

anonrig commented Dec 12, 2023

Thank you @zcorpan. Accepted the invitation.

@nomadtechie
Copy link
Member Author

Wooohoo! Awesome - thanks for your help on this, Simon! Welcome and good luck, Daniel and Yagzi!!! 🥳

@lemire
Copy link
Member

lemire commented Dec 12, 2023

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants