-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Pipeline run queued and not restarted #46378
Comments
@TalbotG I don't know what the problem is. But what we usually do is to close and reopen a PR to re-trigger all the checks. That's the first thing that I would suggest to do. If that doesn't help maybe someone else has more ideas. |
I see that the checks are passing on the PR now. In https://github.com/web-platform-tests/wpt/runs/25140134004 (for commit b119144) I think the problem was actually that the Taskcluster tasks were cancelled for some reason. Closing this as the problem did not persist. |
@foolip Philip, Where exactly do you see that the checks are passing or have passed? When I visit b119144 I see: " and when I visit https://github.com/web-platform-tests/wpt/runs/25140134004 I see a red circle with some green at top-left corner The commit is preceded by a red "x" in the #42345 page [Addendum] It does not perform or execute. |
I do see "All checks have passed" but that is for the last commit, which is commit 48b9f4a . When I visit again b119144 I still see: " When I visit again https://github.com/web-platform-tests/wpt/runs/25140134004 I still see a red circle with some green at top-left corner.
But what about commit b119144 ? It will not register. It will not modify the tests. Submiting the PR will not register, will not embed commit b119144 There are 18 commits in PR42345. Only 17 commits will modify the tests. The commit b119144 will not modify the tests because of what I quoted up here. |
The "Re-run all checks" button does not work for a particular, specific commit. It only works for the last commit. |
What does "This run will be cleaned up after 10 days based on your project settings." mean? |
At the bottom of the page |
Yes, that is correct. As I stated earlier you have to close and reopen the PR to trigger the checks again. |
Henrik, I closed and reopened Pull Request 42345 a few min ago. The 19 Continuous Integration checks started, ran (but I did not see which commit it was running on) and when I visit again b119144 , I still see: |
@TalbotG the PR is once again passing the checks. If you get it reviewed and still can't merge it, let me know and I can check why CI is failing. |
Philip, I am mostly concerned about the changes, the modifications in commit b119144 if I review and approve the PR. I want the changes and modifications (removing the margin-top as the label given to the commit states) to be registered, to be carried over (I can not find the correct verb here) when I approve and merge the #42345. Anyway... I will try to approve and to merge the #42345 tomorrow. |
@TalbotG if the checks are passing on the pull request and you squash all the commits when you merge, then none of the original commits will really matter. The CI failures that were on the branch also don't get in the way of merging as long as they're fixed in subsequent commits. |
I do not know for sure if they were fixed in subsequent commits. In my opinion, they were not. I just approve the whole #42345 a few min. ago. [fingers crossed] I will close this Issue as soon as I know for sure that the failing commit b119144 (with 10 canceled checks) in #42345 was successfully squashed and merged (or registered or embedded) . |
Sounds good. Thanks for letting us know! |
@foolip , @jcscottiii , @gsnedders , @whimboo
Dear github admins and fellow colleagues,
In Pull Request 42345 , commit b119144 failed and I do not know why.
After searching, I end up in this Azure Pipeline page or in this Azure Pipeline Run page and I still can not figure out why the commit b119144 failed and what his author , @SebastianZ , can do and should do.
The text was updated successfully, but these errors were encountered: