Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for server-timing/ #6980

Open
foolip opened this issue Aug 23, 2017 · 3 comments
Open

Suggestions for server-timing/ #6980

foolip opened this issue Aug 23, 2017 · 3 comments
Labels

Comments

@foolip
Copy link
Contributor

@foolip foolip commented Aug 23, 2017

  • Add @cvazac and any other interested implementers to OWNERS
  • Test invalid production of https://w3c.github.io/server-timing/#the-server-timing-header-field, for example if metric-value starts with a 0. Does any deviation from the ABNF have the same effect? If not, this needs to somehow be accounted for in the spec.
  • Test what happens when there are two headers with different values. First wins, last wins, or error?
@cvazac

This comment has been minimized.

Copy link
Contributor

@cvazac cvazac commented Aug 24, 2017

I'm trying to land a change to the ABNF which allows for a duration of ".5" (no leading "0").

What invalid production of the header do you have in mind?

@foolip

This comment has been minimized.

Copy link
Contributor Author

@foolip foolip commented Aug 25, 2017

A missing leading zero was the first that came to mind, but anything that might plausibly differ in a generated parser and a hand-written one would be good to cover. For example, leading, trailing and extra semicolons, i.e. permutations of "Server-Timing: ;metric1=1.2;;document;"

And names that aren't valid productions of token in https://tools.ietf.org/html/rfc7230

@foolip

This comment has been minimized.

Copy link
Contributor Author

@foolip foolip commented Oct 25, 2019

@cvazac I see that you did #13789 last year, does that cover the suggestions in this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.