Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package.json: change of node >= 6 to node >= 16 should be a minor version upgrade? #824

Closed
DonHason opened this issue Jul 10, 2023 · 1 comment
Closed

package.json: change of node >= 6 to node >= 16 should be a minor version upgrade? #824

DonHason opened this issue Jul 10, 2023 · 1 comment

Comments

@DonHason
Copy link

Just an idea, not a bug issue.

The change from

  "engines": {
    "node": ">= 6"
  }

to

  "engines": {
    "node": ">= 16"
  }

,in the patch version 3.3.6, should be minor version upgrade to 3.7.0?

For me it feels kinda harsh to dismiss 10 node versions in a patch version upgrade.

Feel free to close this issue, if you have a different opinion.
@marco-c
Copy link
Member

marco-c commented Jul 10, 2023

It was a mistake to have >= 6, those Node versions were already not supported for a while.

@marco-c marco-c closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marco-c @DonHason