Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrobble filters (Remastered, Explicit) #1643

Closed
thomwim opened this issue Jun 4, 2018 · 4 comments · Fixed by #3671
Closed

Scrobble filters (Remastered, Explicit) #1643

thomwim opened this issue Jun 4, 2018 · 4 comments · Fixed by #3671
Labels
core This issue or pull request is related to the extension core feature New feature or request

Comments

@thomwim
Copy link

thomwim commented Jun 4, 2018

On YouTube, the add-on has a filter that removes "official video" from the tags. Can you extend this feature into other websites?

Or remove the following case-sensitive phrases from track or albums: "explicit", "remastered" (with any year),...

@inverse
Copy link
Member

inverse commented Jun 6, 2018

This could be extended to other sites. The whole filter logic could be made extendable via the options to allow selection to use per-connector. however this is a significant overhaul.

@inverse inverse added feature New feature or request core This issue or pull request is related to the extension core labels Jun 6, 2018
@thomwim
Copy link
Author

thomwim commented Jun 22, 2018

Okay, for now I'll edit the tags.

@thwaller
Copy link

I question this.... the portion of "official video" I do not. However, "explicit" is in fact a different recording from the clean version. Now "remastered", that is technically a different resulting recording, but all said and done is the same.

My point... please consider in detail the removal of relevant extra title information and how it relates to the recording and the differences between the other possible "versions" of said recording.

@revalenz
Copy link

I question this.... the portion of "official video" I do not. However, "explicit" is in fact a different recording from the clean version. Now "remastered", that is technically a different resulting recording, but all said and done is the same.

But for example, Amazon music shows "[Explicit]" for every song that has explicit content, even if a clean version doesn't exist. (And also in many albums that have at least one explicit song) And even if it exists, the clean version is the one that should have a special suffix, since the "Explicit" version is usually the original song.

It would be great if you can support maybe global filters configurable by the user. (Like a list of words to remove everywhere) (Maybe a list of "suffixes" to remove everywhere?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core This issue or pull request is related to the extension core feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants