Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use content claims #26

Merged
merged 6 commits into from
May 28, 2024
Merged

feat!: use content claims #26

merged 6 commits into from
May 28, 2024

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented May 17, 2024

Converts hoverboard to use content claims and request blocks via byte ranges from blob serving locaitons.

BREAKING CHANGE: hoverboard no longer uses R2 binding, and does not talk to DynamoDB or S3. Instead it uses content claims to determine block locations.

@alanshaw alanshaw marked this pull request as ready for review May 23, 2024 14:15
@alanshaw alanshaw changed the title feat: use content claims feat!: use content claims May 23, 2024
Copy link

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Things get so much simpler, that's so great! Everything looks good from my eyes, but would be great to wait for @Gozala 's review, as I am not really familiar with this code base and there are a lot core changes that could use extra eyes

wrangler.toml Show resolved Hide resolved
src/blocks.js Outdated Show resolved Hide resolved
@alanshaw alanshaw merged commit c25860c into main May 28, 2024
1 check passed
@alanshaw alanshaw deleted the feat/use-content-claims branch May 28, 2024 10:59
alanshaw pushed a commit that referenced this pull request May 28, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.0.0](v1.3.2...v2.0.0)
(2024-05-28)


### ⚠ BREAKING CHANGES

* hoverboard no longer uses R2 binding, and does not talk to DynamoDB or
S3. Instead it uses content claims to determine block locations.

### Features

* use content claims
([#26](#26))
([c25860c](c25860c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants