New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: get react file-upload example working with vite #203
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bc5ed29:
|
`create-react-app` projects don't have the proper loaders to handle loading typescript in dependencies. `vite` is used in our other examples so it makes sense to me that we'd use it for react as well. putting this in a separate PR before I update all the other examples to get feedback before committing to this approach, and to avoid too many merge conflicts with the efforts underway to update examples by @cmunns and @natevw
b17ce5c
to
bc5ed29
Compare
LGTM, only question is does it make it more confusing for beginners to get hacking on it? Probably it's fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Overall looks good to me too. +1 on giving the JSX files an actual I don't think this will cause me much grief merging with my changes on #204, although it might be worth discussing the plan for all the other examples — I'm happy to merge this as a smaller trial run but otoh I don't see a big reason not to just plow forward with similar changes on all examples at once? |
ok amazing - @alanshaw I'd like your signoff before I convert the rest of the examples to vite - happy to add that to this PR if we're all aligned |
I don't think so honestly - tbh I would never recommend more detailed CRA vs Vite breakdown here: https://semaphoreci.com/blog/vite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 happy to use newer and better tooling and it's nice to have consistency with other examples anyway.
following the example of #203, move the rest of the react examples to vite
following the example of #203, move the rest of the react examples to vite
create-react-app
projects don't have the proper loaders to handle loading typescript in dependencies.vite
is used in our other examples so it makes sense to me that we'd use it for react as well.putting this in a separate PR before I update all the other examples to get feedback before committing to this approach, and to avoid too many merge conflicts with the efforts underway to update examples by @cmunns and @natevw