Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Default sort by should be newest to oldest #1295

Merged
merged 2 commits into from
May 5, 2022
Merged

fix: Default sort by should be newest to oldest #1295

merged 2 commits into from
May 5, 2022

Conversation

joannaong
Copy link
Contributor

@joannaong joannaong commented May 3, 2022 •
edited

fixes #1185

@joannaong joannaong requested a review from orvn May 3, 2022 20:18
@joannaong joannaong linked an issue May 3, 2022 that may be closed by this pull request
Default sort by should be newest to oldest #1185
Closed
@joannaong joannaong self-assigned this May 3, 2022
@orvn
Copy link
Contributor

orvn commented May 5, 2022

Actually I noticed that although the order of the sort dropdown options were changed, the default sort was not newest (even though newest appeared first). Resolved that in the commit above.

@orvn orvn merged commit b0da078 into main May 5, 2022
@orvn orvn deleted the fix/sort-by-newest branch May 5, 2022 06:15
@github-actions github-actions bot mentioned this pull request May 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orvn orvn orvn approved these changes

Assignees

@joannaong joannaong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default sort by should be newest to oldest
2 participants
@joannaong @orvn