Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default PSA pin status filter #1364

Open
mbommerez opened this issue May 26, 2022 · 4 comments
Open

Default PSA pin status filter #1364

mbommerez opened this issue May 26, 2022 · 4 comments
Assignees
@joshJarr
Labels
P2 Medium: Good to have, but can wait until someone steps up pi/psa-follow-up topic/psa

Comments

@mbommerez
Copy link

mbommerez commented May 26, 2022 •
edited

Sister issue to nftstorage/nft.storage#1936

status filter is not a required param, it should be implicity set to 'pinned' when not set by the client.
@dchoi27 dchoi27 added topic/psa pi/psa-follow-up P2 Medium: Good to have, but can wait until someone steps up labels May 26, 2022
@alanshaw
Copy link
Member

Please hold off on this, I think I misinterpreted something. nftstorage/nft.storage#1936 (comment) SORRY!

@mbommerez
Copy link
Author

@alanshaw Can you confirm this can be closed?

CC @flea89

@mbommerez
Copy link
Author

Let's have a look into the merged PR for NFT and double check with @alanshaw about being compliant to the spec or not.

@flea89
Copy link
Contributor

flea89 commented Nov 7, 2022

This has been done as part of #2091 !

Also open an issue on the compliance tool to discuss some inconsistencies we have with the spec.

@flea89 flea89 removed their assignment Nov 11, 2022
@joshJarr joshJarr self-assigned this Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshJarr joshJarr

Labels
P2 Medium: Good to have, but can wait until someone steps up pi/psa-follow-up topic/psa
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alanshaw @flea89 @joshJarr @dchoi27 @mbommerez