fix: no page reload when pointing to relative path in docs #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orvn
suggested changes
Jun 28, 2022
There was a problem hiding this comment.
@joannaong looks good overall, but I'm seeing a bug with one of the links that seems otherwise valid.
Steps to reproduce
- In the build preview, see this page (
docs/reference/js-client-library) - The 3rd link in the content
content identifier (CID)is italicized - Clicking this link throws a type error
Looks like the issue might have to do with nesting, since there's markdown within the link content (_ rendering as <em>).
orvn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue where, after docs links were tested and modified to use absolute paths, they all triggered a page reload. Because all links paths start with
/docs/foo, they are treated as regular links that the client handles, rather than Next's built-in virtual routing.