Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE - Upload & Pins file manager table refactor #1836

Closed
joshJarr opened this issue Sep 2, 2022 · 3 comments
Closed

FE - Upload & Pins file manager table refactor #1836

joshJarr opened this issue Sep 2, 2022 · 3 comments
Assignees
Labels
topic/pagination topic/pot Issues handled by PT.

Comments

@joshJarr
Copy link
Contributor

joshJarr commented Sep 2, 2022

There's been a few issues related to the uploads and pins tables.

  • Pagination code is tough to work with since there are many components changing data, and Upload and Pin logic is tightly coupled.
  • There's some inefficiencies in calls, sometimes the table is loaded before requesting pins, resulting in content jumping shortly after loading
  • when "View results" is change when on page 2 or more and causes the request to be out of range the table breaks. Refreshing does not fix this as the url params persist the broken state.
  • Pins cannot be sorted
  • We have lost pagination counts (only get prev, next, first, last), a user cannot jump to a page beyond these.
@joshJarr joshJarr added the topic/pot Issues handled by PT. label Sep 2, 2022
@joshJarr
Copy link
Contributor Author

joshJarr commented Sep 2, 2022

Linked PR: #1699

@flea89 flea89 changed the title FE Upload & Pins table refactor FE - Upload & Pins file manager table refactor Sep 5, 2022
@joshJarr
Copy link
Contributor Author

joshJarr commented Sep 5, 2022

This PR now has a few conflicts for us to fix since a hotfix was merged #1739
We should ensure the hotfixed issues have not regressed due to our conflict management.

@joshJarr joshJarr transferred this issue from storacha-network/w3name Sep 5, 2022
@joshJarr joshJarr linked a pull request Sep 5, 2022 that will close this issue
@mbommerez
Copy link

Closing this as it's covered by other smaller tickets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/pagination topic/pot Issues handled by PT.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants