fix: login redirect should preserve query parameters #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewdelano
force-pushed
the
fix/complete-login-redirect
branch
from
3c8cdb1
to
fcebe5e
Compare
drewdelano
force-pushed
the
fix/complete-login-redirect
branch
from
6faa882
to
58865d5
Compare
jsdevel
approved these changes
Oct 11, 2022
johnathonroach
pushed a commit
that referenced
this pull request
Oct 13, 2022
🤖 I have created a release *beep* *boop* --- ## [2.26.0](website-v2.25.0...website-v2.26.0) (2022-10-13) ### Features * tie in currentPlan into storage useage meter ([#2015](#2015)) ([a4ad62e](a4ad62e)) ### Bug Fixes * login redirect should preserve query parameters ([#2012](#2012)) ([477cf73](477cf73)) * missing prop for cc form in confirm modal ([#2007](#2007)) ([6b6ee15](6b6ee15)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.notion.so/Ensure-redirect-from-Pricing-page-takes-you-to-post-login-modal-of-selected-tier-e9fb5131d7b2486596de0d8c17f77161
This PR is a follow up to a conversation BenGo (not tagging him here to avoid notification noise) and I had a couple of weeks ago. The high level summary is:
Something like the pricing page could use a
requiresAuth: truebehavior. This would function similar to theredirectTo: '...'behavior, except it would capture the url and handle the redirecting automatically. This is important for tiered pricing because otherwise we can't include which tier the customer selected on the public pricing page before we redirect to the authenticated accounts payment page because theredirectTomust be static.