New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add css only logo carousel #2022
Conversation
packages/website/pages/pricing.js
Outdated
<div className="wrapping-logos-inner"> | ||
<div className="wrapping-logos-images"> | ||
<div className="block image-block"> | ||
<Img src="/images/logos/nft-storage.png" alt="NFT Storage" layout="fill" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be nice if this was driven from an array of logos, but I think this is fine too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great idea actually! bc the set repeats itself so this would be handy.
package-lock.json
Outdated
@@ -36331,7 +36333,7 @@ | |||
"@web3-storage/db": "^4.0.0", | |||
"@web3-storage/multipart-parser": "^1.0.0", | |||
"@web3-storage/tools": "^1.0.0", | |||
"@web3-storage/toucan-js": "*", | |||
"@web3-storage/toucan-js": "^2.7.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't tell if this is concerning or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably just from pulling latest and installing deps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than possible package-lock.json weirdness
@cmunns is it possible to have it look less jittery. Maybe it was my screen but the logos were hard to read. |
Can you upload a video of what you're seeing by chance? |
To resolve the conflicts with main, all I had to do was |
Love the tbt |
Lookin good on https://staging.web3.storage/pricing/ |
🤖 I have created a release *beep* *boop* --- ## [2.28.0](website-v2.27.0...website-v2.28.0) (2022-10-18) ### Features * add css only logo carousel ([#2022](#2022)) ([5d96ddc](5d96ddc)) * update testimonials ([#2032](#2032)) ([c8d9299](c8d9299)) * website link component defaults target to _blank when the href is external ([#2038](#2038)) ([947e764](947e764)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Screen.Recording.2022-10-11.at.11.18.04.AM.mov