Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add css only logo carousel #2022

Merged
merged 4 commits into from Oct 18, 2022
Merged

feat: add css only logo carousel #2022

merged 4 commits into from Oct 18, 2022

Conversation

cmunns
Copy link
Contributor

@cmunns cmunns commented Oct 11, 2022

Screen.Recording.2022-10-11.at.11.18.04.AM.mov

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2022

@cmunns cmunns temporarily deployed to production October 11, 2022 18:30 Inactive
<div className="wrapping-logos-inner">
<div className="wrapping-logos-images">
<div className="block image-block">
<Img src="/images/logos/nft-storage.png" alt="NFT Storage" layout="fill" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice if this was driven from an array of logos, but I think this is fine too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea actually! bc the set repeats itself so this would be handy.

@@ -36331,7 +36333,7 @@
"@web3-storage/db": "^4.0.0",
"@web3-storage/multipart-parser": "^1.0.0",
"@web3-storage/tools": "^1.0.0",
"@web3-storage/toucan-js": "*",
"@web3-storage/toucan-js": "^2.7.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't tell if this is concerning or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably just from pulling latest and installing deps?

Copy link
Contributor

@drewdelano drewdelano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than possible package-lock.json weirdness

@heyjay44
Copy link
Contributor

@cmunns is it possible to have it look less jittery. Maybe it was my screen but the logos were hard to read.

@cmunns
Copy link
Contributor Author

cmunns commented Oct 11, 2022

@cmunns is it possible to have it look less jittery. Maybe it was my screen but the logos were hard to read.

Can you upload a video of what you're seeing by chance?

@cmunns cmunns temporarily deployed to production October 12, 2022 19:34 Inactive
@gobengo
Copy link
Contributor

gobengo commented Oct 18, 2022

To resolve the conflicts with main, all I had to do was npm install --package-lock-only https://stackoverflow.com/questions/55599356/what-does-npm-i-package-lock-only-do

@gobengo gobengo temporarily deployed to production October 18, 2022 17:25 Inactive
@gobengo
Copy link
Contributor

gobengo commented Oct 18, 2022

Love the tbt <marquee /> (as @drewdelano put it), but with CSS animations! nice work yall

@gobengo gobengo merged commit 5d96ddc into main Oct 18, 2022
@gobengo gobengo deleted the feat/pricing-page-logos branch October 18, 2022 17:27
@gobengo
Copy link
Contributor

gobengo commented Oct 18, 2022

Lookin good on https://staging.web3.storage/pricing/

gobengo pushed a commit that referenced this pull request Oct 18, 2022
🤖 I have created a release *beep* *boop*
---


##
[2.28.0](website-v2.27.0...website-v2.28.0)
(2022-10-18)


### Features

* add css only logo carousel
([#2022](#2022))
([5d96ddc](5d96ddc))
* update testimonials
([#2032](#2032))
([c8d9299](c8d9299))
* website link component defaults target to _blank when the href is
external
([#2038](#2038))
([947e764](947e764))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants