feat: website link component defaults target to _blank when the href is external #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is to an origin different than the current document
3 tasks
|
I verified the desired behaviors on the preview link (i.e. ensuring that the footer links for 'Status' and 'Open an Issue' now open in a new tab for me because now they render with attr |
yusefnapora
reviewed
Oct 17, 2022
…ops.target provided
…logic. Only footer links use the logic to provide target=_blank
Co-authored-by: Yusef Napora <yusef@napora.org>
gobengo
pushed a commit
that referenced
this pull request
Oct 18, 2022
🤖 I have created a release *beep* *boop* --- ## [2.28.0](website-v2.27.0...website-v2.28.0) (2022-10-18) ### Features * add css only logo carousel ([#2022](#2022)) ([5d96ddc](5d96ddc)) * update testimonials ([#2032](#2032)) ([c8d9299](c8d9299)) * website link component defaults target to _blank when the href is external ([#2038](#2038)) ([947e764](947e764)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
How?
<Link />component will enforce the logic @jchris requested