The usage of the ethereum-bloom-filters library in 4.x

[luu-alex]

Looked into the web3-utils validation issue functions we should be implementing in 4.x,
For 1.x we used the library ethereum-bloom-filters for the functions:
isBloom
isUserEthereumAddressInBloom
isContractAddressInBloom
isTopic
isTopicInBloom
isInBloom
Was thinking we can reuse the same library for these functions for 4.x , wanted to see if anyone had thoughts

[nazarhussain]

I believe ethereum-bloom-filters is the best package for this particular usage. We can proceed with it, unless we have any particular reason not to.

[spacesailor24]

• isBloom would be simple to implement ourselves (copy/paste, no dependencies)
• isUserEthereumAddressInBloom
  Uses
  • isBloom
  • isAddress (included in our library)
  • padLeft (included in our library)
  • isInBloom
    Uses
    • bytesToHex (included in our library)
    • keccak256 (included in our library)
    • codePointToInt (copy/paste, no dependencies)
• isContractAddressInBloom
  Uses
  • isBloom
  • isAddress
  • isInBloom
• isTopic (copy/paste, no dependencies)
• isTopicInBloom
  Uses
  • isBloom
  • isTopic
  • isInBloom

---

The above shows that it would be fairly trivial to implement the needed methods ourselves. ethereum-bloom-filters has one dependency: js-sha3 which hasn't been touched in 3 years

My recommendation: Implement the needed methods ourselves, copy/pasting what we can, and integrate ethereum-bloom-filters's tests

[jdevcs]

These functions are not complex to implement and it will reduce dependency on external lib as discussed , so sol: Implement the needed methods ourselves.